Merge pull request #87 from rndquu/feat/new-priority-msg

feat: new error msg on missing required label
ubiquity-os-marketplace · Nov 18, 2024 · ee4f7c6 · ee4f7c6
2 parents 0480ab3 + ef6198a
commit ee4f7c6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/src/handlers/shared/start.ts b/src/handlers/shared/start.ts
@@ -22,11 +22,14 @@ export async function start(
 
   if (requiredLabelsToStart.length && !requiredLabelsToStart.some((label) => issueLabels.includes(label))) {
     // The "Priority" label must reflect a business priority, not a development one.
-    throw logger.error("This task does not reflect a business priority at the moment and cannot be started. This will be reassessed in the coming weeks.", {
-      requiredLabelsToStart,
-      issueLabels,
-      issue: issue.html_url,
-    });
+    throw logger.error(
+      `This task does not reflect a business priority at the moment. You may start tasks with one of the following labels: ${requiredLabelsToStart.join(", ")}`,
+      {
+        requiredLabelsToStart,
+        issueLabels,
+        issue: issue.html_url,
+      }
+    );
   }
 
   if (!sender) {

diff --git a/tests/main.test.ts b/tests/main.test.ts
@@ -292,7 +292,9 @@ describe("User start/stop", () => {
     context.adapters = createAdapters(getSupabase(), context);
 
     await expect(userStartStop(context)).rejects.toMatchObject({
-      logMessage: { raw: "This task does not reflect a business priority at the moment and cannot be started. This will be reassessed in the coming weeks." },
+      logMessage: {
+        raw: "This task does not reflect a business priority at the moment. You may start tasks with one of the following labels: Priority: 3 (High), Priority: 4 (Urgent), Priority: 5 (Emergency)",
+      },
     });
   });
 });