Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing release v1.34.1 #909

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Preparing release v1.34.1 #909

merged 4 commits into from
Dec 11, 2023

Conversation

cinchurge
Copy link
Collaborator

[1.34.1] - 2023-12-11

Fixed

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7a9f9e) 89.16% compared to head (6f3c38c) 89.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #909      +/-   ##
==========================================
+ Coverage   89.16%   89.23%   +0.06%     
==========================================
  Files          43       43              
  Lines        4515     4515              
==========================================
+ Hits         4026     4029       +3     
+ Misses        373      371       -2     
+ Partials      116      115       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

version.go Outdated Show resolved Hide resolved
Copy link

@rabbbit rabbbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please fix the version first.

@cinchurge cinchurge merged commit 7576b14 into dev Dec 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants