fix: Php8.4 take 2 #839
Merged
fix: Php8.4 take 2 #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aa90ec7. fix: Reverted depreciation change for PHPUnit fix: PHP 8.4 support added
|
Let's get this merged for the next release. The PR was previously approved, I just fixed the errors from the tests. If there are any further issues, then I can fix. But that would also indicate there is a mismatch between the main branch tests and PR branches, which we should figure out. |
Thanks for pointing this out. I'll check this once. Let's try to merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pushed the fix to the old branch. The fix is removing the typed parameters from Twilio\Version::stream. Not sure why I changed this, as it was not typed in a doc block. But also not sure why the tests on the branch would not fail in the same way.
Once we are confident all the tests that should run pass, we should be able to merge again.