Refactor element-specific behavior out of ListModel #8212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paw-hub
force-pushed
the
refactor-listmodel
branch
5 times, most recently
from
370a923 to
0526659
Compare
paw-hub
changed the title
paw-hub
force-pushed
the
refactor-listmodel
branch
from
0526659 to
931b436
Compare
3 tasks
charlag
force-pushed
the
dev-mail
branch
2 times, most recently
from
0b4b27d to
e86dad5
Compare
paw-hub
force-pushed
the
refactor-listmodel
branch
from
931b436 to
0136a8e
Compare
charlag
reviewed
Jan 9, 2025
src/common/misc/ListModel.ts
Outdated
| @@ -25,23 +22,37 @@ import { ListFetchResult, PageSize } from "../gui/base/ListUtils.js" | |||
| import { isOfflineError } from "../api/common/utils/ErrorUtils.js" | |||
| import { ListAutoSelectBehavior } from "./DeviceConfig.js" | |||
|
|
|||
| export type ListModelConfig<ListElementType> = { | |||
| export type ListModelConfig<ElementType, IdType> = { | |||
There was a problem hiding this comment.
ElementType is also an existing type, might be confusing to shadow it
src/common/misc/ListModel.ts
Outdated
| return settledThen(this.loading, what) | ||
| } | ||
|
|
||
| addToLoadedEntities(entity: ElementType) { |
There was a problem hiding this comment.
should maybe not refer to entities in the names since we have specific meaning for it
|
Good job! I hope this is enough |
paw-hub
force-pushed
the
refactor-listmodel
branch
5 times, most recently
from
3707808 to
33bd027
Compare
charlag
approved these changes
Jan 10, 2025
paw-hub
force-pushed
the
refactor-listmodel
branch
from
33bd027 to
50f8d71
Compare
We do not want ListModel to specifically only work on ListElement types, or even element types in general. As such, we generalize it to a list of some kind of elements with some kind of ID, even if these are not types that would be stored remotely as part of the model. Also renames entity/element to item for the ListModel. Closes #8222 Co-authored-by: hrb-hub <[email protected]>
paw-hub
force-pushed
the
refactor-listmodel
branch
from
50f8d71 to
ce112b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.