Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a typo in the description of a column #1947

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

badideasforsale
Copy link
Contributor

@badideasforsale badideasforsale commented Oct 23, 2023

This is a minor fix to the .inspect aws_organizations_account command; the text currently refers to a permission set, but should refer to an AWS account. This PR corrects the text in the description.

Current output:

> .inspect aws_organizations_account
+------------------+--------------------------+----------------------------------------------------------------------------------+
| column           | type                     | description                                                                      |
+------------------+--------------------------+----------------------------------------------------------------------------------+
| _ctx             | jsonb                    | Steampipe context in JSON form, e.g. connection_name.                            |
| account_id       | text                     | The AWS Account ID in which the resource is located.                             |
| akas             | jsonb                    | Array of globally unique identifier strings (also known as) for the resource.    |
| arn              | text                     | The Amazon Resource Name (ARN) of the account.                                   |
| email            | text                     | The email address associated with the AWS account.                               |
| id               | text                     | The unique identifier (account ID) of the member account.                        |
| joined_method    | text                     | The method by which the account joined the organization.                         |
| joined_timestamp | timestamp with time zone | The date the account became a part of the organization.                          |
| name             | text                     | The description of the permission set.                                           |
| partition        | text                     | The AWS partition in which the resource is located (aws, aws-cn, or aws-us-gov). |
| region           | text                     | The AWS Region in which the resource is located.                                 |
| status           | text                     | The status of the account in the organization.                                   |
| tags             | jsonb                    | A map of tags for the resource.                                                  |
| tags_src         | jsonb                    |                                                                                  |
| title            | text                     | Title of the resource.                                                           |
+------------------+--------------------------+----------------------------------------------------------------------------------+

Correct output should be

| name             | text                     |  The name of the member account.                                         |

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
Add example SQL query results here (please include the input queries as well)

Copy link
Contributor

@cbruno10 cbruno10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@badideasforsale Please see review question, thanks!

aws/table_aws_organizations_account.go Outdated Show resolved Hide resolved
@badideasforsale
Copy link
Contributor Author

@cbruno10 yup, accepted the proposed change. I think this is the friendly name, but there's at least a couple of ways to name an AWS account. 😖 But your proposal more aligns with the documentation most likely associated with this result... I think.

@cbruno10 cbruno10 merged commit 3c4b775 into turbot:main Oct 24, 2023
@cbruno10
Copy link
Contributor

Thanks @badideasforsale for the fix!

@cbruno10 cbruno10 added the hacktoberfest-accepted This pull request has been accepted for Hacktoberfest label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted This pull request has been accepted for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants