Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease boost dependency to 1.72.0 #20

Merged
merged 5 commits into from
Nov 1, 2021
Merged

Conversation

Jean1995
Copy link
Member

Boost version 1.75.0 is only supported on Linux kernels newer than 4.11 due to some changes in the release.

However, cubic_interpolation is also running fine with boost version 1.74.0.

To support older Linux kernels, it would be nice to decrease the requirement of the boost version (at least until we absolutely need something from a newer boost package).

This would solve this issue in PROPOSAL, at least for now.

We would also have to apply this change in conan-center-index.

@MaxSac
Copy link
Collaborator

MaxSac commented Oct 29, 2021

i think setting the dependency to the minimum required version would be more consistent. could you try if it still works correctly with boost 1.69?

@Jean1995
Copy link
Member Author

i think setting the dependency to the minimum required version would be more consistent. could you try if it still works correctly with boost 1.69?

I tried installing cubic-interpolation using boost 1.71, however this did not work since cardinal_cubic_b_spline.hpp has been introduced in version 1.72.

But I can try if version 1.72 works.

@Jean1995
Copy link
Member Author

With version 1.72 of boost, building cubic_interpolation and running the tests worked on all systems that I have available (arch Linux, Scientific Linux 7.9, macOS Catalina).

@Jean1995 Jean1995 changed the title Decrease boost dependency to 1.74.0 Decrease boost dependency to 1.72.0 Oct 29, 2021
INSTALL.md Outdated Show resolved Hide resolved
@MaxSac MaxSac merged commit 2db9995 into main Nov 1, 2021
@MaxSac MaxSac deleted the decrease_boost_dependency branch November 1, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants