feat(ecmascript): Implement JSON.stringify
#527
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
reviewed
Jan 14, 2025
| } | ||
| } | ||
|
|
||
| impl From<PrimitiveObjectData> for Value { |
There was a problem hiding this comment.
suggestion: IntoPrimitive as well? And perhaps create IntoValue based on that?
| @@ -317,6 +528,424 @@ fn internalize_json_property<'a>( | |||
| ) | |||
| } | |||
|
|
|||
| struct JSONSerializationRecord { | |||
| replacer_function: Option<Function<'static>>, | |||
There was a problem hiding this comment.
note: These should rather be scoped values: Function<'static> together with a GcScope basically just means "first sign of GC, and this is all invalid" :)
| fn serialize_json_property( | ||
| agent: &mut Agent, | ||
| state: &mut JSONSerializationRecord, | ||
| key: String<'static>, |
There was a problem hiding this comment.
note: You want to take a PropertyKey here and not call ToString on numbers too early. You'll want to instead only serialize those into strings when you're writing them into the JSON buffer, and then wrap them with " to get "automatic" formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I probably need to do some scoping/binding magic with some of my values still.