Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vm): more abstract operations #50

Merged
merged 20 commits into from
Dec 17, 2023
Merged

feat(vm): more abstract operations #50

merged 20 commits into from
Dec 17, 2023

Conversation

lino-levan
Copy link
Contributor

No description provided.

@lino-levan lino-levan changed the title feat(vm): more abstraction operations feat(vm): more abstract operations Oct 30, 2023
aapoalas
aapoalas requested changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking like a nice start! Some issues and some nitpicks left as comments.

Thanks for working on this <3

nova_vm/src/ecmascript/abstract_operations/type_conversion.rs Outdated Show resolved Hide resolved
nova_vm/src/ecmascript/abstract_operations/type_conversion.rs Outdated Show resolved Hide resolved
nova_vm/src/ecmascript/abstract_operations/type_conversion.rs Outdated Show resolved Hide resolved
nova_vm/src/ecmascript/abstract_operations/type_conversion.rs Outdated Show resolved Hide resolved
nova_vm/src/ecmascript/abstract_operations/type_conversion.rs Show resolved Hide resolved
nova_vm/src/ecmascript/abstract_operations/type_conversion.rs Outdated Show resolved Hide resolved
nova_vm/src/ecmascript/abstract_operations/type_conversion.rs Outdated Show resolved Hide resolved
nova_vm/src/ecmascript/abstract_operations/type_conversion.rs Outdated Show resolved Hide resolved
nova_vm/src/ecmascript/abstract_operations/type_conversion.rs Outdated Show resolved Hide resolved
nova_vm/src/ecmascript/abstract_operations/type_conversion.rs Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Oct 31, 2023

@aapoalas Approve the CI workflow?

@ghost
Copy link

ghost commented Nov 2, 2023

I'll give us a macro for this form of matching you're doing, soon

@ghost
Copy link

ghost commented Nov 2, 2023

After those two commits (and probably re-formatting), LGTM.

@ghost ghost mentioned this pull request Nov 3, 2023
Merged
@sno2 sno2 enabled auto-merge (squash) November 8, 2023 13:58
aapoalas
aapoalas previously approved these changes Dec 16, 2023
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one nit

@aapoalas aapoalas force-pushed the feat-more-abstract-ops branch from a12a8b0 to e054f53 Compare December 17, 2023 11:08
@aapoalas aapoalas requested a review from a user December 17, 2023 11:08
aapoalas
aapoalas previously approved these changes Dec 17, 2023
View reviewed changes
@aapoalas aapoalas disabled auto-merge December 17, 2023 11:08
@aapoalas aapoalas enabled auto-merge (squash) December 17, 2023 11:09
@aapoalas aapoalas dismissed ghost ’s stale review December 17, 2023 11:14

Stale review

@aapoalas aapoalas merged commit 7400d31 into trynova:main Dec 17, 2023
1 check passed
@lino-levan lino-levan deleted the feat-more-abstract-ops branch December 17, 2023 11:36
@andreubotella andreubotella mentioned this pull request Jul 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aapoalas aapoalas aapoalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lino-levan @aapoalas @sno2