refactor(number): remove value conversion indirection #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Oct 30, 2023
| Value::Float(n) => n % 1.0 == 0.0 && n % 2.0 == 0.0, | ||
| _ => unreachable!(), | ||
| Number::Integer(n) => Into::<i64>::into(n) % 2 == 0, | ||
| Number::Float(n) => n % 1.0 == 0.0 && n % 2.0 == 0.0, |
There was a problem hiding this comment.
Nice catch, would you like to PR it?
There was a problem hiding this comment.
Actually, isn't the test the wrong way around as well? 3 % 2 == 1 right?
There was a problem hiding this comment.
huh, yeah. not sure what I was thinking when I wrote that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the old code that used to convert to a value before matching on itself to use the enum variants.