Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecmascript): Implement ArrayBuffer Object sub-type #44

Merged
merged 1 commit into from
Oct 30, 2023
Merged

feat(ecmascript): Implement ArrayBuffer Object sub-type #44

merged 1 commit into from
Oct 30, 2023

Conversation

aapoalas
Copy link
Collaborator

Implements ArrayBuffer properly as a sub-type of Object (and Value). This PR should serve as a good guideline on how Object sub-types are implemented at their most basic, though ArrayBuffer is probably the only one that is quite as simple as this.

sno2
sno2 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@sno2 sno2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this all plays together really nice :)

@aapoalas aapoalas merged commit b4ab96b into main Oct 30, 2023
1 check passed
@aapoalas aapoalas deleted the feat/ecmascript-array-buffer-internal-methods branch October 30, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sno2 sno2 sno2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aapoalas @sno2