Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Makie in [weakdeps] to 0.22, (keep existing compat) #2235

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Makie package from 0.19, 0.20 to 0.19, 0.20, 0.22.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ranocha ranocha force-pushed the compathelper/new_version/2025-01-15-00-05-29-351-00716684826 branch from 8f8d55d to 0fe4024 Compare January 15, 2025 00:05
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.37%. Comparing base (fafa540) to head (980d700).
Report is 9 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (fafa540) and HEAD (980d700). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (fafa540) HEAD (980d700)
unittests 25 24
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2235      +/-   ##
==========================================
- Coverage   96.42%   91.37%   -5.05%     
==========================================
  Files         487      489       +2     
  Lines       39352    39371      +19     
==========================================
- Hits        37942    35974    -1968     
- Misses       1410     3397    +1987     
Flag Coverage Δ
unittests 91.37% <ø> (-5.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sloede
sloede previously approved these changes Jan 16, 2025
@sloede sloede enabled auto-merge (squash) January 16, 2025 12:52
@ranocha ranocha disabled auto-merge January 17, 2025 15:54
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses an old version in the CI tests, see https://github.com/trixi-framework/Trixi.jl/actions/runs/12809282620/job/35713778198?pr=2235#step:7:227. Please do not merge such updates where the new versions of the dependencies are not tested.

…eep existing compat) (#2236)

Co-authored-by: CompatHelper Julia <[email protected]>
…eep existing compat) (#2237)

Co-authored-by: CompatHelper Julia <[email protected]>
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we have a chance to see whether the new versions are used in CI. @MarcoArtiano Could you please check that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants