-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for Makie in [weakdeps] to 0.22, (keep existing compat) #2235
base: main
Are you sure you want to change the base?
CompatHelper: bump compat for Makie in [weakdeps] to 0.22, (keep existing compat) #2235
Conversation
8f8d55d
to
0fe4024
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2235 +/- ##
==========================================
- Coverage 96.42% 91.37% -5.05%
==========================================
Files 487 489 +2
Lines 39352 39371 +19
==========================================
- Hits 37942 35974 -1968
- Misses 1410 3397 +1987
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It uses an old version in the CI tests, see https://github.com/trixi-framework/Trixi.jl/actions/runs/12809282620/job/35713778198?pr=2235#step:7:227. Please do not merge such updates where the new versions of the dependencies are not tested.
…eep existing compat) (#2236) Co-authored-by: CompatHelper Julia <[email protected]>
…eep existing compat) (#2237) Co-authored-by: CompatHelper Julia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we have a chance to see whether the new versions are used in CI. @MarcoArtiano Could you please check that?
This pull request changes the compat entry for the
Makie
package from0.19, 0.20
to0.19, 0.20, 0.22
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.