fix: Remove unnecessary pip upgrades in testing #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mc-nv
previously approved these changes
Nov 16, 2024
|
@rmccorm4 , suppose base branch should be |
mc-nv
dismissed
their stale review
Possible that base branch change is required.
mc-nv
approved these changes
Nov 16, 2024
mc-nv
pushed a commit
that referenced
this pull request
Nov 23, 2024
mc-nv
pushed a commit
that referenced
this pull request
Nov 26, 2024
nvda-mesharma
added
Passed_on_A100
Passed_on_H100
and removed
Passed_on_A100
Passed_on_H100
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipinstallation in Ubuntu 24.04 tests by removing thepip install --upgrade pip. The pip upgrade shouldn't be necessary for any installations in these tests.Example error before this change:
$ pip install --upgrade pip Requirement already satisfied: pip in /usr/lib/python3/dist-packages (24.0) Collecting pip Using cached pip-24.3.1-py3-none-any.whl.metadata (3.7 kB) Using cached pip-24.3.1-py3-none-any.whl (1.8 MB) Installing collected packages: pip Attempting uninstall: pip Found existing installation: pip 24.0 ERROR: Cannot uninstall pip 24.0, RECORD file not found. Hint: The package was installed by debian."class has no attribute assertEquals"