Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Downgrade patchelf version from 0.18.0 to 0.17.2 #7959

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

nv-kmcgill53
Copy link
Contributor

@nv-kmcgill53 nv-kmcgill53 commented Jan 22, 2025

What does the PR do?

Downgrade patchelf version from 0.18.0 to 0.17.2 due to patchelf regression

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

Core L0_* tests were segfaulting on loading a shared library used by the pytorch backend. Now they are failing due to known issues with the TensorRT backend.

  • CI Pipeline ID:

22812543

Caveats:

Background

No further explanation required.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

…ession

Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to
0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum
repositories, thus we must use pip to install the version we want.
See mayeut/patchelf-pypi#87
@nv-kmcgill53 nv-kmcgill53 added the PR: build Changes that affect the build system or external dependencies label Jan 22, 2025
build.py Outdated Show resolved Hide resolved
build.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit - please fix pre-commit failures before merge

@nv-kmcgill53 nv-kmcgill53 requested a review from rmccorm4 January 22, 2025 19:05
@nv-kmcgill53 nv-kmcgill53 merged commit fe3fcf7 into r25.01 Jan 22, 2025
3 checks passed
@nv-kmcgill53 nv-kmcgill53 deleted the kmcgill-downgrade-patchelf branch January 22, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: build Changes that affect the build system or external dependencies
Development

Successfully merging this pull request may close these issues.

2 participants