Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template external secrets configs injection #286

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yardenc2003
Copy link
Contributor

The current chart implementation requires static secret and configmap names to be provided in various mount-related values (envFrom, additionalVolumes, secretMounts, etc.).

This creates a challenge when the Trino chart is deployed as part of a parent chart, with multiple deployments in the same namespace.
Similar to the Trino chart (which uses {{ template "trino.fullname" . }}- for unique resource names), the parent chart resource names are often rendered according to release-specific values, so the static naming requirement for these mounts of resources external in the Trino chart creates a limitation in such scenarios.

Similar PRs have been raised in the past, including one I previously opened and closed because the use case wasn’t sufficiently justified at the time. In this case, however, the justification is clear: the current implementation prevents deploying a parent chart multiple times in the same namespace when Trino is a subchart, which I believe is a common use case.

I’ve updated the tests to demonstrate that the templating works correctly for resource names. However, the coverage may not include all the tpl changes I’ve introduced. Please let me know if additional test updates or further modifications are needed.

@cla-bot cla-bot bot added the cla-signed label Jan 12, 2025
@yardenc2003 yardenc2003 force-pushed the template-external-secrets-configs-injection branch from d36176a to 21670f1 Compare January 12, 2025 13:47
@shohamyamin
Copy link

This will be great especially when you want to have several Trino clusters as sub charts with a gateway in the same chart

@nineinchnick nineinchnick added the enhancement New feature or request label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants