Template external secrets configs injection #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current chart implementation requires static secret and configmap names to be provided in various mount-related values (
envFrom
,additionalVolumes
,secretMounts
, etc.).This creates a challenge when the Trino chart is deployed as part of a parent chart, with multiple deployments in the same namespace.
Similar to the Trino chart (which uses
{{ template "trino.fullname" . }}-
for unique resource names), the parent chart resource names are often rendered according to release-specific values, so the static naming requirement for these mounts of resources external in the Trino chart creates a limitation in such scenarios.Similar PRs have been raised in the past, including one I previously opened and closed because the use case wasn’t sufficiently justified at the time. In this case, however, the justification is clear: the current implementation prevents deploying a parent chart multiple times in the same namespace when Trino is a subchart, which I believe is a common use case.
I’ve updated the tests to demonstrate that the templating works correctly for resource names. However, the coverage may not include all the
tpl
changes I’ve introduced. Please let me know if additional test updates or further modifications are needed.