Feature/api v3/merge #265
Merged
Feature/api v3/merge #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md
- introduce new model class `AppError` - make `ExceptionsControllerAdvice` use this new class
as a core word for this project, this change affects a lot of files a brief summary follows: - REST API endpoints - `/data/sales` -> `/data/orders` - `/data/sell_statuses` -> `/data/order_statuses` - security authorities - `sales:*` -> `orders:*` - `sell_statuses:*` -> `order_statuses:*` - API models, JPA entities and QueryDSL counterparts - `Sell` -> `Order` - `SellDetail` -> `OrderDetail` - `SellStatus` -> `OrderStatus` - services for CRUD, conversion, data patching and sorting - JPA repositories - property `trebol.api.able-to-edit-sales-after-being-processed` - `trebol.api.able-to-edit-orders-after-being-processed` - SQL schema tables, columns, constraints, indexes and initial values - also entity table mappings - constants and variables
the `OrderPojo` class must instead relate to two instances of `PersonPojo` in turn, fix all code bits affected by this change, including unit tests also update changelog
all POST requests return 201 (excepting `/data/orders/*`) all PUT,PATCH,DELETE,OPTIONS requests return 204
`/public/checkout/result/{token}`
has the same purposes that
`/public/receipt/{token}`
does
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the newest iteration of the base API document. The following changes were made:
AppErrorExceptionsControllerAdviceuse this new class on all its methodsSellandSalestoOrderandOrdersrespectively/data/sales->/data/orders/data/sell_statuses->/data/order_statusessales:(create|read|update|delete)->orders:(...)sell_statuses:(create|read|update|delete)->order_statuses:(...)trebol.api.able-to-edit-sales-after-being-processedtrebol.api.able-to-edit-orders-after-being-processedorg.trebol.api.models.SellPojo->OrderPojoSellDetailPojo->OrderDetailPojoSellStatusPojo->OrderStatusPojoservices.(for both interfaces and implementations)SalesProcessService->OrdersProcessServiceorg.trebol.jpa.entities.(and their QueryDSL counterparts)Sell->OrderSellDetail->OrderDetailSellStatus->OrderStatusrepositories.SalesRepository->OrdersRepositorySellDetailsRepository->OrderDetailsRepositorySellStatusesRepository->OrderStatusesRepositorysortspecs.SalesSortSpec->OrdersSortSpecSellStatusesSortSpec->OrderStatusesSortSpecservices.(for both interfaces and implementations)crud.SalesCrudService->OrdersCrudServiceSellStatusesCrudService->OrderStatusesCrudServicepatch.SalesPatchService->OrdersPatchServiceSellStatusesPatchService->OrderStatusesPatchServiceconversion.SalesConverterService->OrdersConverterServiceSellStatusesConverterService->OrderStatusesConverterServicepredicates.SalesPredicateService->OrdersPredicateServiceSellStatusesPredicateService->OrderStatusesPredicateServiceCustomerPojoandSalespersonPojoclassesOrderPojoclass now relates to two instances ofPersonPojoinstead/dataendpoints/data/orders/confirmation/data/orders/rejection/data/orders/completionThere is one thing left however. The auth-related resources that were removed from the specification will be still very much needed, and so this backend implementation will still have them.
And so! They must be properly documented.