Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JDK #264

Merged
merged 11 commits into from
Aug 29, 2024
Merged

Update JDK #264

merged 11 commits into from
Aug 29, 2024

Conversation

bglamadrid
Copy link
Collaborator

@bglamadrid bglamadrid commented Aug 29, 2024

PR Checklist

  • Read the contribution guidelines
  • Added a brief description of these changes to the top of the changelog
  • Changes in code meet test criteria (running mvn test returns exit code 0, without errors)

PR Type

  • Refactoring (changes that do not affect API nor functionality)
  • Build-related

Summary

Resolve #263

Also bump Spring Boot version.

Additional info

Tested against JDK 17, 19 and 21.

- Change project object artefact id
  - Add suffix `-java17`
- Update endorsed java version to `17`
- Update `spring-boot-starter-parent` library to `2.7.18`
To remain in a working state, the following changes needed to be made:

- Update `lombok` to version `1.18.34`
- Remove enforced `groovy` version
- Remove explicit version tag for `mockito-inline` library
- Migrate FQDN for some core libraries
  - `javax.persistence` ->  `jakarta.persistence`
  - `javax.servlet` ->  `jakarta.servlet`
  - `javax.validation` ->  `jakarta.validation`
- Add required `jakarta` classifier to `querydsl` dependencies
- Migrate `SecurityConfig` to Spring Security 5.8
- Migrate/fix all affected unit tests
To remain in a working state, the following changes
needed to be made:

- update `SecurityConfig` following deprecations in Spring Security 6.1
- remove unused unresolved `mockito-inline` dependency
- fix all affected integration tests
  - most of which needed a renewed custom `SecurityConfig`, mind you
no additional steps were needed for this migration
the application, its unit and integration tests all work fine
- update artifact id with `-java21` suffix
- use inherited lombok library version variable
- remove other two inherited maven plugin version variables
- update changelog
- update readme
@bglamadrid bglamadrid changed the title Update JDK to 21 Update JDK Aug 29, 2024
Copy link

@bglamadrid bglamadrid merged commit a3d15f4 into main Aug 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update JDK to 21
1 participant