-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JDK #264
Merged
Merged
Update JDK #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change project object artefact id - Add suffix `-java17` - Update endorsed java version to `17` - Update `spring-boot-starter-parent` library to `2.7.18`
To remain in a working state, the following changes needed to be made: - Update `lombok` to version `1.18.34` - Remove enforced `groovy` version - Remove explicit version tag for `mockito-inline` library - Migrate FQDN for some core libraries - `javax.persistence` -> `jakarta.persistence` - `javax.servlet` -> `jakarta.servlet` - `javax.validation` -> `jakarta.validation` - Add required `jakarta` classifier to `querydsl` dependencies - Migrate `SecurityConfig` to Spring Security 5.8 - Migrate/fix all affected unit tests
To remain in a working state, the following changes needed to be made: - update `SecurityConfig` following deprecations in Spring Security 6.1 - remove unused unresolved `mockito-inline` dependency - fix all affected integration tests - most of which needed a renewed custom `SecurityConfig`, mind you
no additional steps were needed for this migration the application, its unit and integration tests all work fine
- update artifact id with `-java21` suffix - use inherited lombok library version variable - remove other two inherited maven plugin version variables
- update changelog - update readme
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
mvn test
returns exit code 0, without errors)PR Type
Summary
Resolve #263
Also bump Spring Boot version.
Additional info
Tested against JDK 17, 19 and 21.