Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output float dtype in fusion #2671

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix output float dtype in fusion #2671

merged 1 commit into from
Jan 8, 2025

Conversation

laggui
Copy link
Member

@laggui laggui commented Jan 8, 2025

Checklist

  • Confirmed that run-checks all script has been executed.

Changes

With the addition of float_cast op, some output were still incorrectly being initialized as the default elem type. Fixed that to use the input dtype.

@laggui laggui merged commit 9367b16 into main Jan 8, 2025
9 checks passed
@laggui laggui deleted the fix/fusion/float-dtype branch January 8, 2025 16:53
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.16%. Comparing base (e2fa9c4) to head (be761b7).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2671      +/-   ##
==========================================
+ Coverage   83.14%   83.16%   +0.02%     
==========================================
  Files         839      841       +2     
  Lines      107913   107958      +45     
==========================================
+ Hits        89719    89781      +62     
+ Misses      18194    18177      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants