Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasserstein Generative Adversarial Network #2660

Merged
merged 45 commits into from
Jan 15, 2025
Merged

Conversation

wangjiawen2013
Copy link
Contributor

Wasserstein Generative Adversarial Network imlemented in Burn

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.19%. Comparing base (93cafc4) to head (575e4b5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2660   +/-   ##
=======================================
  Coverage   83.19%   83.19%           
=======================================
  Files         819      819           
  Lines      106748   106761   +13     
=======================================
+ Hits        88811    88824   +13     
  Misses      17937    17937           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Glad to see you got your example to work after all our small discussions here and there 😄

I'll take some time to review this later today or tomorrow and test it, do your samples look similar to the pytorch example?

The CI is complaining about some formatting if you have some time to fix that.

Thanks for the PR 🙏

@wangjiawen2013
Copy link
Contributor Author

Yes, they look similar. Here is an comparison with pytorch, and you can find more images generated by pytorch wgan on https://bytepawn.com/training-a-pytorch-wasserstain-mnist-gan-on-google-colab.html
image

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review 😅 was busy with the preparation for yesterday's release.

The example is good! Instead of commenting for the restructure to follow the other workspace examples I made the changes myself.

The performance could probably be improved on GPU, but at least now we have a GAN example 😄

@laggui laggui merged commit f630b3b into tracel-ai:main Jan 15, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants