Fix

tracel-ai · Jan 8, 2025 · c1f9f1b · c1f9f1b
1 parent d62d022
commit c1f9f1b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 27 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -153,11 +153,11 @@ ahash = { version = "0.8.11", default-features = false }
 portable-atomic-util = { version = "0.2.4", features = ["alloc"] }
 
 ### For the main burn branch. ###
-cubecl = { git = "https://github.com/tracel-ai/cubecl", default-features = false, rev = "29f57359dc223dfda0e7de0c63bb8c641598c3c4" }
-cubecl-common = { git = "https://github.com/tracel-ai/cubecl", default-features = false, rev = "29f57359dc223dfda0e7de0c63bb8c641598c3c4" }
+# cubecl = { git = "https://github.com/tracel-ai/cubecl", default-features = false, rev = "29f57359dc223dfda0e7de0c63bb8c641598c3c4" }
+# cubecl-common = { git = "https://github.com/tracel-ai/cubecl", default-features = false, rev = "29f57359dc223dfda0e7de0c63bb8c641598c3c4" }
 ### For local development. ###
-# cubecl = { path = "../cubecl/crates/cubecl", default-features = false }
-# cubecl-common = { path = "../cubecl/crates/cubecl-common", default-features = false }
+cubecl = { path = "../cubecl/crates/cubecl", default-features = false }
+cubecl-common = { path = "../cubecl/crates/cubecl-common", default-features = false }
 ### For the release. ###
 # cubecl = { version = "0.3.0", default-features = false }
 # cubecl-common = { version = "0.3.0", default-features = false }

diff --git a/crates/burn-jit/src/kernel/conv/conv2d/tune/conv2d.rs b/crates/burn-jit/src/kernel/conv/conv2d/tune/conv2d.rs
@@ -147,7 +147,6 @@ fn should_run<R: JitRuntime, F: FloatElement>(
         _ => true,
     };
 
-    println!("{index} => {should_run}");
     should_run
 }
 
@@ -168,17 +167,8 @@ fn can_launch<S: ConvSelector<ImplicitCmmaConv>, R: JitRuntime, CS: ConvPrecisio
     let (selection, config_input) = S::select_kernel::<R, CS>(plane_dim);
     let cube_dim = ImplicitCmmaConv::cube_dim(&selection);
     let cube_count = ImplicitCmmaConv::cube_count(&selection, conv_problem);
-
-    let max_cube_dim = 65535;
-
-    if let cubecl::CubeCount::Static(x, y, z) = cube_count {
-        println!("({x}, {y}, {z})");
-        if x > max_cube_dim || y > max_cube_dim || z > max_cube_dim {
-            return false;
-        }
-    }
-
     let advanced_config = Default::default();
+
     let config = ImplicitCmmaConv::make_config(
         config_input,
         conv_problem,

diff --git a/crates/burn-jit/src/kernel/conv/error.rs b/crates/burn-jit/src/kernel/conv/error.rs
@@ -12,6 +12,7 @@ impl From<MatmulLaunchError> for ConvLaunchError {
     }
 }
 
+#[allow(clippy::from_over_into)]
 impl Into<AutotuneError> for ConvLaunchError {
     fn into(self) -> AutotuneError {
         AutotuneError::Unknown(format!("{self:?}"))