Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stratum: fix address ownership check for new bitcoin core based wallets #347

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

uhliksk
Copy link

@uhliksk uhliksk commented Apr 20, 2019

Instead of using predefined coin ticker we should use universal method to detect new bitcoin core based daemons using getaddressinfo only for ismine info.

@tpruvot
Copy link
Owner

tpruvot commented Apr 20, 2019

need to check ismine on getaddressinfo too

@uhliksk
Copy link
Author

uhliksk commented Apr 21, 2019

need to check ismine on getaddressinfo too

ismine on getaddressinfo is passed into json_result and checked later in code, you don't need to check if it is actually there as missing ismine is considered same way as false

@tpruvot tpruvot removed the invalid label Apr 22, 2019
if(!json_get_bool(json_result, "ismine"))
{
stratumlog("%s wallet is using getaddressinfo.\n", coind->name);
getaddressinfo = true;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a json_value_free(json); here to free validateaddress replaced one

@dmitriy79
Copy link

dmitriy79 commented Apr 28, 2019

Some coins are not suitable for yimp pool. Workers find blocks, but they do not fall into the database for payment, are not shown in the blocks found ... What parameter needs to be changed so that the blocks found are taken into account and entered into the database?,

@nymbuzcumulus
Copy link

nymbuzcumulus commented Aug 25, 2024

yiimp installed and accesible via ssh,,, How to I make it work witth Bitcoin core installed on second server on my network ? Help please !
I am only interested on BTC,, have 50 miners I wish to make em work on Solo Pool minin, using yiimp and btc core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants