-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize build #18
optimize build #18
Conversation
Might also want to do an |
.DS_Store
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this file
btw, the tests do not run on
Replacing import currentPkg from "../package.json" with { type: "json" }; |
sure |
ok, i will push it, not related to this PR though i believe |
the high vulnerability is only in dev dep like webpack and rollup which is part of torus-scripts, will ask chai to update torus0-scripts but it doesnt affect post build code running |
currently most of us in org are using node 20 LTS |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As pointed out by @metalurgical , I think it would be good to run npm audit fix
to clear the vulnerability reports. Anyhow, will approve, as this is not related to the changes of this PR and could be done later.
Final reduction: