-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto-complete to the P5 widget #81
Draft
citelao
wants to merge
48
commits into
toolness:master
Choose a base branch
from
citelao:feature/monaco
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citelao
commented
Dec 28, 2021
"chai": "^3.5.0", | ||
"webpack-dev-server": "^1.14.1" | ||
"mocha-chrome": "^2.2.0", | ||
"mocha-phantomjs": "^4.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove obsolete phantomjs
citelao
commented
Dec 28, 2021
@@ -47,6 +62,14 @@ module.exports = configurations({ | |||
'preview-frame': './lib/preview-frame.ts', | |||
'tests': './test/main.tsx' | |||
}, | |||
devServer: { | |||
// historyApiFallback: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (super preliminary) draft change adds IntelliSense/autocomplete to the editor!
To best handle this change, I switched the editor from CodeMirror to Monaco (the base of VS Code), since Monaco handles autocomplete much better (and by default!). This required a lot of other changes---updating the Webpack versions significantly, etc.
There's a ton of work left---
the editor is mis-sized(fixed!)and does not support undo/redo yet(supports undo now!). See the TODOs!But wow, it's so cool!
Example
You can mess with it at https://ben.stolovitz.com/p5.js-widget/!
Previous screenshots
Before style changes:
Notes
@types/p5
since that is used for the auto-complete (yeah, ew).index.html
etc tostatic/
.TODO