WIP: Distinguish different distributions for paramiko dependency #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different distributions all use different package names for the `python-paramiko` dependency. Sometimes there are multiple such packages, one for Python 2.x and one for Python 3.x. Since this is ultimately used by duplicity itself, the correct version to install is the one for the Python version used by the duplicity installation.
|
Looks good to me! Let me know when this is ready for merge. |
goetzk
reviewed
Jan 13, 2021
| @@ -20,6 +20,26 @@ | |||
| 'Debian' => 'apt', | |||
| default => 'archive' | |||
| } | |||
|
|
|||
| if $facts['os']['name'] == 'Ubuntu' { | |||
There was a problem hiding this comment.
Note that this same split is applicable for Debian from the next release:
Stable + Oldstable Python 2 https://packages.debian.org/buster/duplicity
Testing python 3 https://packages.debian.org/bullseye/duplicity
I'm not sure when the next release of this role will be but this might be relevant as the next Debian release is expected in 2-3 months. https://wiki.debian.org/DebianBullseye
goetzk
reviewed
Jan 13, 2021
| @@ -20,6 +20,26 @@ | |||
| 'Debian' => 'apt', | |||
| default => 'archive' | |||
| } | |||
|
|
|||
| if $facts['os']['name'] == 'Ubuntu' { | |||
| $duply_paramiko_package_name = versioncmp($facts['os']['release']['major'], '20.04') >= 0 ? { | |||
There was a problem hiding this comment.
Enabling backups of 20.04 systems would be of interest to me too. @punycode is there any help I can provide in getting this included?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different distributions all use different package names for the
python-paramikodependency. Sometimes there are multiple such packages, one for Python 2.x and one for Python 3.x. Since this is ultimately used by duplicity itself, the correct version to install is the one for the Python version used by the duplicity installation.We therefore depend on the Python version that comes with the distribution
duplicitypackage.PS: I'm not very good at Puppet RSpec tests and I did not find any regarding the
python-paramikodependency, that I could adapt. Perhaps someone would like to pick up my proposal and add these tests.PPS: The
Fedorabranches for thepython-paramikodependency are a guess from what ever information I could pull from public package repository information. All our Puppet-managed Fedora boxes are currently in Corona home office isolation and not easily reachable. The RHEL ones are also a bit problematic, since they actually depend on EPEL. Should we depend on theepel-releasepackage here?