Use variables [generate_params and server_name] in generate.py #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like `generate_params` are duplicated, so i used the variable
pandermatt
changed the title
pandermatt
commented
Apr 26, 2023
| @@ -192,7 +186,7 @@ def generate_with_streaming(**kwargs): | |||
| ], | |||
| title="🦙🌲 Alpaca-LoRA", | |||
| description="Alpaca-LoRA is a 7B-parameter LLaMA model finetuned to follow instructions. It is trained on the [Stanford Alpaca](https://github.com/tatsu-lab/stanford_alpaca) dataset and makes use of the Huggingface LLaMA implementation. For more information, please visit [the project's website](https://github.com/tloen/alpaca-lora).", # noqa: E501 | |||
| ).queue().launch(server_name="0.0.0.0", share=share_gradio) | |||
| ).queue().launch(server_name=server_name, share=share_gradio) | |||
There was a problem hiding this comment.
we can use the variable from the parameter
Shevilll
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
generate_paramsare duplicated, so i used the variable