Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression: Missing "disable-output-buffering" option since meson builds #1814

Conversation

malwarectigouvfr
Copy link
Contributor

The Meson build system was missing the disable-output-buffering option, which is available in the Make build system. This commit adds the disable-output-buffering option to the Meson build system.

… builds

The Meson build system was missing the `disable-output-buffering` option, which is available in the Make system. This commit adds the `disable-output-buffering` option to the Meson build.
@malwarectigouvfr malwarectigouvfr force-pushed the fix_regression_disable_output_buffering branch from 414c4e3 to 4b2338a Compare November 21, 2024 10:33
@malwarectigouvfr
Copy link
Contributor Author

Build fails because repository SubhookLib/subhook pulled by Xen has gone private recently. This is a known issue for projects relying on OVMF. The current xen submodule's master branch didn't fix this issue yet.

@drakvuf-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@malwarectigouvfr
Copy link
Contributor Author

Thanks for the fix. You'll need to add disable-output-buffering to meson_options.txt as well.

Nice catch, thanks. I just pushed the fix.

@tklengyel tklengyel merged commit 0b4796a into tklengyel:main Nov 22, 2024
33 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants