Feedback from review

.github/workflows/ci.yml

@@ -3,9 +3,6 @@ on:
   - push
   - pull_request
 
-env:
-  CI: 1
-
 defaults:
   run:
     shell: bash

compose.yaml

@@ -20,21 +20,8 @@ services:
       - django
     volumes:
       - .:/app
-
-  celerybeat:
-    container_name: tin_celerybeat
-    image: tin-base
-    entrypoint:
-      - celery
-      - -A
-      - tin
-      - beat
-    networks:
-      - tin-network
-    volumes:
-      - .:/app
-    depends_on:
-      - django
+    environment:
+      IN_DOCKER: true
 
   django:
     container_name: tin_django
@@ -55,6 +42,8 @@ services:
       - redis
     healthcheck:
       test: ["CMD", "curl", "-f", "http://0.0.0.0:8000"]
+    environment:
+      IN_DOCKER: true
 
 networks:
   tin-network:

tin/settings/__init__.py

@@ -28,7 +28,7 @@
 # SECURITY WARNING: don't run with debug turned on in production!
 DEBUG = True
 
-CI = "CI" in os.environ
+IN_DOCKER = os.environ.get("IN_DOCKER", False)
 
 ALLOWED_HOSTS = [
     "127.0.0.1",
@@ -110,7 +110,7 @@
         "BACKEND": "channels_redis.core.RedisChannelLayer",
         "CONFIG": {
             "hosts": [
-                ("redis" if not CI and DEBUG else "localhost", 6379),
+                ("redis" if IN_DOCKER else "localhost", 6379),
             ]
         },
     },
@@ -240,7 +240,7 @@
 CELERY_RESULT_BACKEND = "django-db"
 
 
-if not CI and DEBUG:
+if IN_DOCKER:
     CELERY_BROKER_URL = "redis://redis:6379/0"
 else:
     CELERY_BROKER_URL = "redis://localhost:6379/1"