Fix pre-commit ci errors

pyproject.toml

@@ -130,8 +130,6 @@ ignore = [
   "PLR09",
   # magic number comparison
   "PLR2004",
-  # fixtures not returning anything should have leading underscore
-  "PT004",
   # mutable class attrs annotated as typing.ClassVar
   "RUF012",
   # missing docstring

tin/apps/assignments/models.py

@@ -36,12 +36,12 @@ class Folder(models.Model):
     def __str__(self):
         return self.name
 
-    def get_absolute_url(self):
-        return reverse("assignments:show_folder", args=[self.course.id, self.id])
-
     def __repr__(self):
         return self.name
 
+    def get_absolute_url(self):
+        return reverse("assignments:show_folder", args=[self.course.id, self.id])
+
 
 class AssignmentQuerySet(models.query.QuerySet):
     def filter_permissions(self, user, *perms: Literal["-", "r", "w"]):
@@ -186,12 +186,12 @@ class Assignment(models.Model):
     def __str__(self):
         return self.name
 
-    def get_absolute_url(self):
-        return reverse("assignments:show", args=(self.id,))
-
     def __repr__(self):
         return self.name
 
+    def get_absolute_url(self):
+        return reverse("assignments:show", args=(self.id,))
+
     def make_assignment_dir(self) -> None:
         """Creates the directory where the assignment grader scripts go."""
         assignment_path = os.path.join(settings.MEDIA_ROOT, f"assignment-{self.id}")
@@ -445,12 +445,12 @@ class Meta:
     def __str__(self):
         return f"Quiz for {self.assignment}"
 
-    def get_absolute_url(self):
-        return reverse("assignments:show", args=(self.assignment.id,))
-
     def __repr__(self):
         return f"Quiz for {self.assignment}"
 
+    def get_absolute_url(self):
+        return reverse("assignments:show", args=(self.assignment.id,))
+
     def issues_for_student(self, student):
         return (
             sum(lm.severity for lm in self.assignment.log_messages.filter(student=student))
@@ -487,12 +487,12 @@ class QuizLogMessage(models.Model):
     def __str__(self):
         return f"{self.content} for {self.assignment} by {self.student}"
 
-    def get_absolute_url(self):
-        return reverse("assignments:student_submission", args=(self.assignment.id, self.student.id))
-
     def __repr__(self):
         return f"{self.content} for {self.assignment} by {self.student}"
 
+    def get_absolute_url(self):
+        return reverse("assignments:student_submission", args=(self.assignment.id, self.student.id))
+
 
 def moss_base_file_path(obj, _):  # pylint: disable=unused-argument
     assert obj.assignment.id is not None
@@ -553,6 +553,9 @@ class MossResult(models.Model):
     def __str__(self):
         return f"Moss result for {self.assignment}"
 
+    def __repr__(self):
+        return f"Moss result for {self.assignment}"
+
     @property
     def extension(self):
         return "java" if self.language == "java" else "py"
@@ -561,9 +564,6 @@ def extension(self):
     def download_folder(self):
         return os.path.join(settings.MEDIA_ROOT, "moss-runs", f"moss-{self.id}")
 
-    def __repr__(self):
-        return f"Moss result for {self.assignment}"
-
 
 def run_action(command: list[str]) -> str:
     """Runs a command.

tin/apps/courses/models.py

@@ -65,12 +65,12 @@ class Course(models.Model):
     def __str__(self):
         return self.name
 
-    def get_absolute_url(self):
-        return reverse("courses:show", args=[self.id])
-
     def __repr__(self):
         return self.name
 
+    def get_absolute_url(self):
+        return reverse("courses:show", args=[self.id])
+
     def get_teacher_str(self) -> str:
         """Get a string of the last names of all teachers in a course"""
         return ", ".join(t.last_name for t in self.teacher.all())
@@ -112,12 +112,12 @@ class Period(models.Model):
     def __str__(self):
         return self.name
 
-    def get_absolute_url(self):
-        return reverse("courses:students", args=[self.course.id]) + f"?period={self.id}"
-
     def __repr__(self):
         return self.name
 
+    def get_absolute_url(self):
+        return reverse("courses:students", args=[self.course.id]) + f"?period={self.id}"
+
 
 class StudentImportUser(models.Model):
     """A student that is to be added to a course when they log in"""
@@ -144,12 +144,12 @@ class Meta:
     def __str__(self):
         return f"Import into {self.course.name}"
 
-    def get_absolute_url(self):
-        return reverse("courses:import_students", args=[self.course.id])
-
     def __repr__(self):
         return f"Import into {self.course.name}"
 
+    def get_absolute_url(self):
+        return reverse("courses:import_students", args=[self.course.id])
+
     def queue_users(self, usernames):
         """Add usernames to a queue of students to add to a course"""
         for username in usernames:

tin/apps/submissions/models.py

@@ -111,18 +111,11 @@ def __str__(self):
             (self.grade_percent if self.has_been_graded else "not graded"),
         )
 
+    __repr__ = __str__
+
     def get_absolute_url(self):
         return reverse("submissions:show", args=[self.id])
 
-    def __repr__(self):
-        return "{}{} [{}]: {} ({})".format(
-            ("[INCOMPLETE] " if not self.complete else ""),
-            self.student.username,
-            self.date_submitted.strftime("%Y-%m-%d %H:%M:%S"),
-            self.assignment.name,
-            (self.grade_percent if self.has_been_graded else "not graded"),
-        )
-
     @property
     def is_on_time(self):
         return self.date_submitted <= self.assignment.due

tin/apps/venvs/models.py

@@ -55,12 +55,12 @@ class Venv(models.Model):
     def __str__(self):
         return self.name
 
-    def get_absolute_url(self):
-        return reverse("venvs:show", args=[self.id])
-
     def __repr__(self):
         return f"<Virtualenv: {self.name}>"
 
+    def get_absolute_url(self):
+        return reverse("venvs:show", args=[self.id])
+
     @property
     def path(self):
         return os.path.join(settings.MEDIA_ROOT, "venvs", f"venv-{self.id}")