Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 ♻️ Rework Docs #2580

Merged
merged 14 commits into from
Dec 15, 2024
Merged

💄 ♻️ Rework Docs #2580

merged 14 commits into from
Dec 15, 2024

Conversation

joshbermanssw
Copy link
Contributor

@joshbermanssw joshbermanssw commented Dec 4, 2024 •
edited
Loading

Welcome to our new look of Tina Docs - cleaner, more responsive and a few updated features

Changes

  • Rebuilt with eliminating alot of styled.jsx (the product-tour page needs to be re-worked still)
  • MD view (<1200px) now removes the right ToC bar and it becomes a tab at the top
  • SM view removes both right ToC bar and left Directory bar and both become tabs at the top
  • SM view incorporates search bar that was introduced in /search page

Screenshot 2024-12-05 at 2 20 46 pm
Figure: SM view of Tina Docs

Screenshot 2024-12-05 at 2 20 56 pm
Figure: MD view of Tina Docs

Screenshot 2024-12-05 at 2 21 08 pm
Figure: LG view of Tina Docs

@vercel Vercel
Copy link

vercel bot commented Dec 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2024 11:23pm

@joshbermanssw joshbermanssw changed the title main of desktop ui 💄 ♻️ Rework Docs Dec 5, 2024
@joshbermanssw joshbermanssw marked this pull request as ready for review December 5, 2024 03:21
@joshbermanssw joshbermanssw requested a review from a team as a code owner December 5, 2024 03:21
joshbermanssw
joshbermanssw commented Dec 5, 2024
View reviewed changes
Copy link
Contributor Author

@joshbermanssw joshbermanssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr rev with Isaac

components/docsMain/docsMobileHeader.tsx Outdated Show resolved Hide resolved
components/docsMain/docsMobileHeader.tsx Outdated Show resolved Hide resolved
components/docsMain/tocOverflowButton.tsx Show resolved Hide resolved
components/layout/DocsLayout.tsx Show resolved Hide resolved
components/tinaMarkdownComponents/docAndBlogComponents.tsx Show resolved Hide resolved
components/tinaMarkdownComponents/docAndBlogComponents.tsx Show resolved Hide resolved
isaaclombardssw
isaaclombardssw approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@isaaclombardssw isaaclombardssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super clean 👌

@bettybondoc
Copy link

bettybondoc commented Dec 5, 2024 •
edited by joshbermanssw
Loading

@joshbermanssw
cc @Marxoz @landonmaxwell @isaaclombardssw

(Feel free to move this to a new PBI)

  • Pagination - Next - Decrease padding-right to align it with the next line
  • Pagination - Introduction to TinaCMS - use text-base
  • Search Bar - Make the padding pb-4 (currently pb-6) on smaller screens
  • Results - Make sure the heading/searchbar/submenu is also present in the results page on smaller screens

image
Figure: Pagination

image
Figure: Search Bar

image

Figure: Results

@landonmaxwell landonmaxwell merged commit 34ae555 into main Dec 15, 2024
4 checks passed
@landonmaxwell landonmaxwell deleted the re-work-docs branch December 15, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaaclombardssw isaaclombardssw isaaclombardssw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshbermanssw @bettybondoc @isaaclombardssw @landonmaxwell