Add waf default core ruleset as configmap #3643
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gantony
reviewed
Dec 10, 2024
gantony
suggested changes
Dec 11, 2024
| @@ -48,23 +48,27 @@ func AsMap() (map[string]string, error) { | |||
| return err | |||
| } | |||
|
|
|||
| if b, err := fs.ReadFile(FS, path); err != nil { | |||
| if d.Name()[0] == '@' { | |||
There was a problem hiding this comment.
not sure why this is done? are we skipping any directories prefixed with '@'? I thought rules were in a directory named '@owasp-' something
There was a problem hiding this comment.
Yes that works by accident, need to make the logic clearer.
There was a problem hiding this comment.
"by accident" i think you mean "very skilfully"
There was a problem hiding this comment.
Changing this turned out to be easier than anticipated 😄
|
Replaced by #3649. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.