Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Handle close code if it was not handled before closing #121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

west0r
Copy link

@west0r west0r commented Apr 6, 2018

WebSocket not handle close code when connection was closed by server.
I handle code on closing.

@snoozemoose
Copy link

snoozemoose commented Mar 20, 2019

@west0r I'm experiencing occasional crashes in handleCloseCodeFromFirstCloseFrameIfNeeded() on the line if frame.code == .close {, is this anything you have seen?

@west0r
Copy link
Author

west0r commented Mar 28, 2019

@snoozemoose no, my problem was related to ability to handle close code. I didn't see any crashes.

@beefon
Copy link

beefon commented May 29, 2019

I'd love this to be merged, so far no crashes for me, but I'd like to switch from locally changed version to the upstream.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants