Skip to content

Commit

Permalink
Improve caldav calendar settings flow (#786)
Browse files Browse the repository at this point in the history
* 🌐 Catch up German translation

* 🔨 Move color palette to definitions

* ➕ Implement CalDAV form feedback flow

* ➕ Add test ids
  • Loading branch information
devmount authored Dec 10, 2024
1 parent 6953e0e commit b09e318
Show file tree
Hide file tree
Showing 6 changed files with 195 additions and 123 deletions.
8 changes: 7 additions & 1 deletion backend/src/appointment/controller/calendar.py
Original file line number Diff line number Diff line change
Expand Up @@ -333,11 +333,17 @@ def test_connection(self) -> bool:
except KeyError as ex:
logging.error(f'KE: Error testing connection {ex}')
return False
except (requests.exceptions.RequestException, caldav.lib.error.NotFoundError, caldav.lib.error.PropfindError) as ex:
except (
requests.exceptions.RequestException,
caldav.lib.error.NotFoundError,
caldav.lib.error.PropfindError,
caldav.lib.error.AuthorizationError
) as ex:
"""
RequestException: Max retries exceeded, bad connection, missing schema, etc...
NotFoundError: Good server, bad url.
PropfindError: Some properties could not be retrieved.
AuthorizationError: Credentials are not accepted.
"""
return False

Expand Down
8 changes: 4 additions & 4 deletions backend/src/appointment/l10n/de/email.ftl
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,14 @@ new-booking-plain = { $name } ({ $email }) hat soeben { $date } gebucht
# $duration (String) - Length of minutes the appointment will be
new-booking-html-heading-name = { $name }
new-booking-html-heading-email = ({ $email })
# FIXME: Google Translate Patch !
new-booking-html-heading-text = hat gerade Zeit im { $schedule_name } gebucht
new-booking-html-time = { $duration } mins
## Confirm Appointment

confirm-mail-subject = Buchungsanfrage von {-brand-name} bestätigen
# Variables
# $name (String) - Name of the person who requested the appointment
confirm-mail-subject = Buchungsanfrage von { $name } bestätigen
# Variables:
# $name (String) - Name of the person who requested the appointment
# $email (String) - Email of the person who requested the appointment
Expand Down Expand Up @@ -85,11 +86,10 @@ confirm-mail-plain = { $name } ({ $email }) hat soeben dieses Zeitfenster aus de
# $date (String) - Date of the requested appointment
# $schedule_name (String) - The name of the schedule used to book the appointment
# $duration (String) - Length of minutes the appointment will be
# FIXME: Google Translation patch !
confirm-mail-html-heading-name = { $name }
confirm-mail-html-heading-email = ({ $email })
confirm-mail-html-heading-text = fordert die Buchung eines Zeitfensters in { $schedule_name } an
confirm-mail-html-time = { $duration } mins
confirm-mail-html-time = { $duration } Minuten
confirm-mail-html-confirm-text = Dieser Link führt zur Bestätigung der Buchungsanfrage:
confirm-mail-html-confirm-action = Buchung bestätigen
Expand Down
Loading

0 comments on commit b09e318

Please sign in to comment.