-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI errors #376
Fix CI errors #376
Conversation
- Until Firedrake issue #3368 is resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cpjordan
So it might be I'm just misunderstanding - but I would have expected that for interpolated value size we should in fact be using value_size
and not block_size
. The latter being the n/o DOFs per node, which was what previously returned by value_size
in which case it would in fact have been incorrect in Thetis previously. The difference would only appear for RT and BDM velocity fields which we don't use very frequently. I do agree/understand the changes to the OP2 kernel headers in utility.py and utility3d.py - these should indeed be block_size
now.
Related to firedrakeproject/firedrake#3862 and firedrakeproject/firedrake#3368 |
- Interested in scalar/vector/tensor not DOF structure - Also simplify to fs.value_shape - no need for ufl_element().value_shape
@stephankramer - thanks for reviewing and explanation. I had discussed the problems with @connorjward who found that Updated based on the comments above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, many thanks!
Fix various issues with testing: