Create tsunami module #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephankramer
previously approved these changes
Feb 29, 2024
There was a problem hiding this comment.
@jwallwork23 : still planning to add more tsunami cases? In any case this seems to move a module from an example to thetis/ - which looks fine to me.
Thanks. No plans to do any tsunami modelling in the near future myself. |
|
[Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor update that's been on my to do list for a while: create a Thetis module for the tsunami utils. Would allow us to consider tsunamis other than Tohoku and will also allow me to write a Tohoku demo (also on the to do list).