Drop unused methods from PosixMemberService #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
changed the title
ekohl
approved these changes
Apr 10, 2024
|
Nit: there's a typo in the first commit message. |
times_in_groups should be unused since baf56b9 merge_filters seems to be used only in times_in_groups
test_missing_user was defined twice, the first implementation wasn't getting run and would fail when made to run. test/posix_test.rb:84: warning: method redefined; discarding old test_missing_user test/posix_test.rb:22: warning: previous definition of test_missing_user was here
lib/ldap_fluff/ad_member_service.rb:60: warning: assigned but unused variable - new_known_groups
in ad member service lib/ldap_fluff/ad_member_service.rb:29: warning: instance variable @domain_functionality not initialized
|
Pardon me showing up, but this seems to be approved, nit resolved and not merged 🤔 |
|
I'm at Panda Circus so I don't mind at all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
times_in_groups should be unused since baf56b9
merge_filters seems to be used only in times_in_groups