Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make guide dropdown scrollable #3559

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Make guide dropdown scrollable #3559

merged 1 commit into from
Jan 10, 2025
+2 −0

Conversation

asteflova
Copy link
Member

What changes are you introducing?

This makes the dropdown lists in the top navigation bar scrollable.

Screenshot From 2025-01-10 14-48-39

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

#2752

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

@asteflova asteflova linked an issue Jan 10, 2025 that may be closed by this pull request
Web page navigation doesn't allow scrolling #2752
Closed
@github-actions GitHub Actions
Copy link

The PR preview for 7157816 is available at theforeman-foreman-documentation-preview-pr-3559.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@asteflova
Copy link
Member Author

The GH preview doesn't show the scrollbar on the landing page but it does show it when I open any of the guides. A local preview (nanoc) does show the scrollbar on the landing page. I wonder why.

@ekohl
Copy link
Member

ekohl commented Jan 10, 2025

The GH preview doesn't show the scrollbar on the landing page but it does show it when I open any of the guides. A local preview (nanoc) does show the scrollbar on the landing page. I wonder why.

I think our previews build web from master, not the PR.

ekohl
ekohl approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Long term I'd love to revisit our navigation altogether but this at least makes it usable in the short term.

@ekohl ekohl merged commit beba65e into theforeman:master Jan 10, 2025
8 checks passed
@asteflova asteflova deleted the website-dropdown-scroll branch January 10, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web page navigation doesn't allow scrolling
2 participants
@asteflova @ekohl