Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: add CountryCode to driver's info. #496

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

harningle
Copy link
Contributor

@harningle harningle commented Dec 24, 2023

This is to fix #493. We forgot to include CountryCode in the below default_keys when fixing #460:

Fast-F1/fastf1/_api.py

Lines 1493 to 1496 in 89033fd

default_keys = [
'RacingNumber', 'BroadcastName', 'FullName', 'Tla', 'Line', 'TeamName',
'TeamColour', 'FirstName', 'LastName', 'Reference', 'HeadshotUrl'
]

I also updated the corresponding testing. CountryCode is not generally available in old races, which means the rawdata from the API of our previous test case 70th Anniversary Grand Prix FP2 does not provide drivers' country info., so we can't test our code either. test_driver_list() is now tested against 2023 Bahrain Grand Prix FP1, so that we can check if we correctly parse the CountryCode.

The linting fails as this pushes to the maintenance-v3.1 branch, rather than master.

@theOehrly theOehrly merged commit be98a4f into theOehrly:maintenance-v3.1 Dec 26, 2023
6 of 7 checks passed
@theOehrly
Copy link
Owner

Perfect, thank you 👍

@harningle harningle deleted the maintenance-v3.1 branch December 26, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants