FIX: add CountryCode to driver's info. #496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #493. We forgot to include
CountryCode
in the belowdefault_keys
when fixing #460:Fast-F1/fastf1/_api.py
Lines 1493 to 1496 in 89033fd
I also updated the corresponding testing.
CountryCode
is not generally available in old races, which means the rawdata from the API of our previous test case 70th Anniversary Grand Prix FP2 does not provide drivers' country info., so we can't test our code either.test_driver_list()
is now tested against 2023 Bahrain Grand Prix FP1, so that we can check if we correctly parse theCountryCode
.The linting fails as this pushes to the maintenance-v3.1 branch, rather than master.