Remove BlueZ dependence #417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Libpcap should not use BlueZ userspace headers, because it does not use BlueZ at all. It used only Linux kernel, but it does not provide userspace headers. For compatible reason we should use own copy of headers and try to dynamically detect Linux kernel version and use proper structures.
Fix some compilator warnings, avoid one using malloc/free Also various white characters fixes.
Closed
|
Does copying the data structures etc. from the Linux kernel headers make the Bluetooth code GPLv2-licensed? If so, that's a problem, as the rest of libpcap is BSD-licensed (and, unfortunately, licensed with the old 4-clause BSD license). |
|
guy, I'm trying to see where the copying of headers occured, and I didn't see it. Maybe I missed it. |
|
I guess my concern is whether the "our own copy" could get people complaining that we just took GPLed code from Linux or not; if it was a reimplementation from scratch (I don't think "clean room" is necessary), that should suffice. |
lkundrak
pushed a commit
to pignus-project/libpcap
that referenced
this pull request
Nov 27, 2016
kernel-devel package was added because I thought it may resolve bluetooth related build failure. After addition of dependency packages started building again however with bluetooth support disabled. Probably the *right* thing to do would be to move away from bluez dependency, because code that use bluez-libs anyway. This is currently discussed upstream. See: the-tcpdump-group/libpcap#417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libpcap should not use BlueZ userspace headers, because it does not
use BlueZ at all. It use only Linux kernel, but it does not
provide userspace headers. For compatible reason we should use own copy
of headers and try to dynamically detect Linux kernel version and use
proper structures.
This fixes #343.
This is the second try of pull request: #347