Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation improvements #316

Merged
merged 50 commits into from
Jan 11, 2023
Merged

Translation improvements #316

merged 50 commits into from
Jan 11, 2023

Conversation

Shebuka
Copy link
Contributor

@Shebuka Shebuka commented Jan 9, 2023

Translation fixes

  • Many translation fixes;
  • Configuration file for i18next-parser;
  • New page descriptions;
  • Removed some unused files;
  • Improves even more Translations 🌐  #175;
  • Added bare bone html for when user enters the site with disabled JavaScript;
  • So much wow!

Shebuka added 30 commits January 7, 2023 22:34
@Shebuka
Fixed combo box text color
811367a
@Shebuka
Merge remote-tracking branch 'origin/translation_terms' into translat…
e28481a 
…ion_terms
@Shebuka
Removed unused history-graphs page
1d19949
@Shebuka
Fix to christmas tree being now removed
b2e6df6
@Shebuka
Traders and trader page title, description and strings fixes;
8eca8a3 
Removed showLoadingPage as we now have always at least some cached data
@Shebuka
Renamed a string
fe1d607
@Shebuka
SEO and Translation improvements;
c8aea21 
Many new page descriptions
@Shebuka
Configuration for i18next-parser
c1725ff
@Shebuka
New translation files generated with i18next-parser
50091b8
@Shebuka
Removed unused item-table component
c55d2e5
@Shebuka
Renamed armor page to armors as other pages are all plurals
0b9269e
@Shebuka
No need for t, station is already localized
89b1262
@Shebuka
Fix key name
a09b870
@Shebuka
Fix header and image on different rows if compressed by a big filter
6dff410
@Shebuka
Added all supported translations to i18next-parser
e787a2c
@Shebuka
Sorted categories by type as we see them in in-game inventory (head -…
8f7c4b4 
…> body -> weapon -> containers -> other items)
@Shebuka
Added label to properties component to properly handle translation
7b9fbaf
@Shebuka
Removed unused quests-list
e78fbb8
@Shebuka
Small fixes to strings
b0a3c20
@Shebuka
Translate filter options in loot tiers
8ff39c6
@Shebuka
Better price tier label category in loot tier page
326b820
@Shebuka
Added map names to t
8d43f5a
@Shebuka
Using i18n list from array and count interpolations
cc23cf0
@Shebuka
Fixed passing locale to TraderResetTime
74ffa4f
@Shebuka
Imported moment/min/locales for moment to work with our locale
5018932
@Shebuka
Added bare bone html for when user enters the site with disabled Java…
c7b5ed6 
…Script
@Shebuka
Fixed using correct map description;
32669cb 
Fixed timers for factory and labs;
Fixed open contributor link in new tab;
@Shebuka
Moved ammo page helmet inside ammo js file
37bebbc
@Shebuka
Page description string now uses key for i18n;
f1e390c 
Fixed helmet react key on all pages
@Shebuka
New translation files generated with i18next-parser
dca0914
@Shebuka
Copy link
Contributor Author

Shebuka commented Jan 11, 2023

.deploy

@github-actions
Copy link
Contributor

⚠️ Cannot proceed with deployment

  • reviewDecision: APPROVED
  • commitStatus: PENDING

CI checks must be passing in order to continue

@Shebuka
Copy link
Contributor Author

Shebuka commented Jan 11, 2023

.deploy

@github-actions
Copy link
Contributor

Deployment Triggered 🚀

Shebuka, started a branch deployment to production

You can watch the progress here 🔗

Branch: translation_improvements

@github-actions github-actions bot temporarily deployed to production January 11, 2023 13:21 Inactive
@github-actions
Copy link
Contributor

Deployment Results ✅

Shebuka successfully deployed branch translation_improvements to production

@Shebuka
Copy link
Contributor Author

Shebuka commented Jan 11, 2023

.deploy

@github-actions
Copy link
Contributor

Deployment Triggered 🚀

Shebuka, started a branch deployment to production

You can watch the progress here 🔗

Branch: translation_improvements

@github-actions github-actions bot had a problem deploying to production January 11, 2023 16:26 Failure
@github-actions
Copy link
Contributor

Deployment Results ❌

Shebuka had a failure when deploying branch translation_improvements to production

@github-actions
Copy link
Contributor

Deployment Triggered 🚀

Shebuka, started a branch deployment to production

You can watch the progress here 🔗

Branch: translation_improvements

@github-actions github-actions bot temporarily deployed to production January 11, 2023 16:31 Inactive
@github-actions
Copy link
Contributor

Deployment Results ✅

Shebuka successfully deployed branch translation_improvements to production

@Razzmatazzz Razzmatazzz merged commit 90dd892 into main Jan 11, 2023
@Razzmatazzz Razzmatazzz deleted the translation_improvements branch January 11, 2023 20:55
@GrantBirki GrantBirki added the language Changes related to wording on the site or translations label Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razzmatazzz Razzmatazzz Razzmatazzz approved these changes

@GrantBirki GrantBirki GrantBirki approved these changes

Assignees
No one assigned
Labels
language Changes related to wording on the site or translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shebuka @Razzmatazzz @GrantBirki