Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fi navlink css #40

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fi navlink css #40

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68e396e
Added navlinkcss file and added styling to navLinks
fab33150 Sep 23, 2020
2d0d6f0
Added icons to list and additem navlinks
fab33150 Sep 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/NavLinks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
import React from 'react';
import { NavLink } from 'react-router-dom';
import './css/NavLinks.css';

const NavLinks = () => (
<div>
<ul>
<li>
<NavLink
to="/list"
activeStyle={{
fontWeight: 'bold',
}}
className="navlink"
activeClassName="navlink-active"
>
List
</NavLink>
</li>
<li>
<NavLink to="/add" activeStyle={{ fontWeight: 'bold' }}>
Add an item
<NavLink to="/add" className="navlink" activeClassName="navlink-active">
Add Item
</NavLink>
</li>
</ul>
Expand Down
20 changes: 20 additions & 0 deletions src/css/NavLinks.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
/* Nav-Link*/
.navlink {
color: #f4a431;
text-decoration: none;
}

.navlink-active {
font-weight: 900;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a font weight of 900? If we're using our font-family: 'Source Sans Pro', sans-serif; as our default font in our App.css, I think we only have 300 and 400 weights downloaded for that font. Please correct me if I'm wrong because I don't know a ton about font weights.

color: white;
}

ul {
list-style-type: none;
margin: 0;
padding: 0;
}

li {
margin: 5px 0px;
}