Reuse PortForwarder container if it is running #680
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #677. Closes #678
The current implementation of the
PortForwarder
relies on a singleton to ensure that multiple forwarders are not started at the same time. The idea is that there is one forwarder per session.The reliance on a singleton falls apart when test suites run in different processes. Similar then to the reaper implementation, we now check for the existence of a forwarder container and reuse it if it exists, instead of creating a new one. This resolves the conflicts reported in #677. This PR additionally handles the case where we attempt to forward the same port multiple times, by querying the forwarder container for its bound ports on error and skipping if already bound.
To do: