Move default container configurations to constructor to allow for overriding #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianrgreco
added
bug
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joebowbeer
reviewed
Sep 9, 2024
| @@ -5,6 +5,8 @@ export const LOCALSTACK_PORT = 4566; | |||
| export class LocalstackContainer extends GenericContainer { | |||
| constructor(image = "localstack/localstack:2.2.0") { | |||
| super(image); | |||
| this.resolveHostname(); | |||
There was a problem hiding this comment.
@cristianrgreco This line should not have been moved. There is no way to provide an environment before the constructor is called so resolveHostname will never resolve LOCALSTACK_HOST
|
Observation: No tests were affected by these changes, indicating that this functionality is not currently tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #711