Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localstack: constructor ignores LOCALSTACK_HOST #833

Closed
joebowbeer opened this issue Sep 9, 2024 · 1 comment · Fixed by #834
Closed

localstack: constructor ignores LOCALSTACK_HOST #833

joebowbeer opened this issue Sep 9, 2024 · 1 comment · Fixed by #834

Comments

@joebowbeer
Copy link
Contributor

joebowbeer commented Sep 9, 2024

The fix to allow wait strategy overrides broke hostname resolution. @cristianrgreco

Originally posted by @joebowbeer in #712 (comment)

The call to resolveHostname was moved into the constructor but it should be made after the environment has been assigned. There is no way to provide an environment before the constructor is called so resolveHostname will never resolve LOCALSTACK_HOST

@joebowbeer
Copy link
Contributor Author

Related preexisting issue: https://github.com/testcontainers/testcontainers-node/pull/640/files#r1752884907

The assignment in resolveHostname of the last network alias to the LOCALSTACK_HOST env var was being made directly, without calling withEnvironment, and was bypassing some code as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant