fix: Adjust aws provider requirements. #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[security_group_referencing_support](terraform-aws-modules#133) requires at least [v5.69.0](https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.69.0)
markshawtoronto
changed the title
|
thats a breaking change and should go out in #113 the issue is that #133 introduced it - @antonbabenko do we roll forward with the complete breaking change, or roll back? |
|
@bryantbiggs I missed that version bump when merging #133. I was unaware of the progress on #113, which looks great. If we can get it released shortly, we can skip thinking about fixing the issue introduced. But in general, we can probably roll forward with the fix based on this PR (#138) without making a major release. WDYT? |
|
Ya I supposed - 6 vs half a dozen at this point. I'll take a look at #113 and wrap that up shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using security_group_referencing_support added in release 2.13.0 requires at least aws provider v5.69.0.
Motivation and Context
Fixes #137
Breaking Changes
NEW: Yes, it's a breaking change, the issue is v2.13.0 does not work without it. Feel free to takeover this PR.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request