-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Typed Search Attributes #553
Open
roxblnfk
wants to merge
22
commits into
master
Choose a base branch
from
search-attributes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typed SA collection: added `withUntypedValue()` method and `fromCollection()` factory
…arch Attribute requests because RR won't send related responses
Increase tests coverage: test TSA unset command; Sync with the new RR spec;
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
roxblnfk
force-pushed
the
search-attributes
branch
from
January 20, 2025 08:10
4c03aea
to
07324fc
Compare
roxblnfk
force-pushed
the
search-attributes
branch
from
January 20, 2025 08:25
07324fc
to
f6660c7
Compare
wolfy-j
approved these changes
Jan 20, 2025
Sushisource
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Exposed Typed Search Attributes:
\Temporal\Common\TypedSearchAttributes
\Temporal\Common\SearchAttributes\SearchAttributeKey
and typed valuesWorkflow::upsertTypedSearchAttributes()
WorkflowOptions::withTypedSearchAttributes()
Fixed:
\Temporal\Internal\Workflow\ScopeContext::upsertSearchAttributes()
changes Search Attributes in the current Workflow stateBased on https://github.com/temporalio/proposals/blob/904b7ed8266b5e6edc0cbf17abcf98fc8de25775/all-sdk/sdk-typed-search-attributes.md?plain=1
Checklist
Examples
Client API
Workflow context