Interceptors OpenTelemetry: Add Docker Compose and the sample more comprehensive #391
+1,634
−291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te config of metrics and traces OTLP endpoints
mjameswh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added a Docker Compose file, and associated configuration files, to demo usage of OpenTelemetry interceptors and Runtime's metrics exports, with an OpenTelemetry collector, Prometheus, Jaeger and Zipkin. This makes it a more appropriate setup to properly demonstrate configuration of a TS SDK-based service with OpenTelemetry-based observability. Resolves [Feature Request] OTel interceptors sample should illustrate how to actually use a collector or other exporters #100.
Modified the sample to initialize OpenTelemetry in a dedicated file that gets loaded before anything else (using
ts-node -r src/interceptor.ts), as recommended in OpenTelemetry's JS SDK's documentation. Resolves [Feature Request] OTel Interceptors: inject OTEL config using--require#378.