Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix]: namespace .Values pointing to nil error fixed #619

Closed

Conversation

itsneel
Copy link

@itsneel itsneel commented Dec 26, 2024

What was changed

$ is appended to make .Values accessible in the template

Why?

Variable global access fixed while creating name spaces in the server via helm

Checklist

  1. How was this tested:
    helm charts built as expected

  2. Any docs updates needed?
    no. its just an values access fix in the template. no need for documentation to be updated

@itsneel itsneel requested a review from a team as a code owner December 26, 2024 17:50
@CLAassistant
Copy link

CLAassistant commented Dec 26, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@itsneel itsneel force-pushed the fix/temporal-namespaces-values-access branch from 79960b4 to 9826f35 Compare December 26, 2024 17:52
@itsneel itsneel changed the title fix: namepsace .Values pointing to nil error fixed [Bugfix]: namespace .Values pointing to nil error fixed Dec 26, 2024
@itsneel itsneel force-pushed the fix/temporal-namespaces-values-access branch from 9826f35 to 2b73588 Compare December 26, 2024 18:55
@itsneel
Copy link
Author

itsneel commented Dec 27, 2024

closing this as already fixed in #617

@itsneel itsneel closed this Dec 27, 2024
@itsneel itsneel deleted the fix/temporal-namespaces-values-access branch December 27, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants