Add support for deployment labels #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you are comfortable enough in Go, please could you add some tests for this to |
|
@robholland I'm fairly early in my Go journey, but based on the tests you recently added I think I've made it.
Happy to hear your feedback! |
|
Added the "inline" refactor on the labels inline method and also added a test for the additional labels, as discussed in #582 |
robholland
approved these changes
Oct 11, 2024
|
Please merge master to get the CI fix. |
asproul
pushed a commit
to asproul/helm-charts
that referenced
this pull request
Dec 16, 2024
* feat: add support for defining deployment labels --------- Co-authored-by: Rob Holland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This PR adds support to define deployment labels for the
server,admintoolsandwebcomponents.NOTE 1: this includes the option to define labels on server level (
server.deploymentLabels) instead of within scope of the server services (frontend, history, matching, worker) only. However to make this work, PR #580 first needs to be merged.NOTE 2: this PR partly replaces #537, however this PR needs revision because of the resourceLabels templatization in PR #539.
Why?
Currently there is no option to define deployment labels.
Checklist
helm install -f values.yaml --set server.deploymentLabels.serverLabel1="serverDeploymentLabel" --set admintools.deploymentLabels.serverLabel1="adminDeploymentLabel" --set web.deploymentLabels.serverLabel1="webDeploymentLabel" debug . --dry-run --debugserverLabel1is added to all server services and admintools and web components.helm install -f values.yaml --set server.deploymentLabels.serverLabel1="serverDeploymentLabel" --set server.frontend.deploymentLabels.resourceLabel1="resourceDeploymentLabel" debug . --dry-run --debugfrontendservice.resourceLabel1is added to the serverfrontendservice. The deployment labels on server level are ignored correctly.serverLabel1is added to the other server services (history,matching,worker).No.