Ensure we use a serviceAccount if we're asked to create one #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the name alone wasn't a good test as they may want the default name.
| @@ -42,7 +42,7 @@ Create the name of the service account | |||
| Define the service account as needed | |||
| */}} | |||
| {{- define "temporal.serviceAccount" -}} | |||
| {{- if .Values.serviceAccount.name -}} | |||
| {{- if or .Values.serviceAccount.name .Values.serviceAccount.create -}} | |||
There was a problem hiding this comment.
this also fixes my original issue at #562
but the reason why I did not choose to perform an "or" check here is because I want to be explicit about the name "default"
Such practice is popular in the community and can be viewed in some widely used charts here:
https://github.com/bitnami/charts/blob/b7bd1ad379e8735003f5d180fc0c79bf773f9ea6/bitnami/cassandra/templates/_helpers.tpl#L36C1-L45C12
https://github.com/prometheus-community/helm-charts/blob/24979b1d1aee425312e039882de3d27c8fa9b607/charts/prometheus/templates/_helpers.tpl#L181-L190
|
Closing in favour of #562 which is a better fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the name alone wasn't a good test as they may want the default name.
What was changed
Set
serviceAccountNameifserviceAccount: { create: true }is set.Why?
Previously we checked only if the default name was being over-ridden. This broke if people wanted to use the default name.
Checklist
Closes
How was this tested: