Refactor: Config and CLI #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklastreml
requested review from
y-eight,
puffitos,
lvlcn-t and
eumel8
as code owners
y-eight
requested changes
Jan 11, 2024
lvlcn-t
reviewed
Jan 11, 2024
lvlcn-t
reviewed
Jan 11, 2024
Signed-off-by: Bruno Bressi <[email protected]>
4 tasks
|
Everything LGTM @niklastreml. I've removed the target manager as well in a separate PR so we can finish this one once and for all. :) |
|
Sounds good 👍 @puffitos |
- chore: remove unused file - chore: latency receiver typo - chore: grammar in root.go - chore: uneeded or removed in charts - chore: identation in chart fixed Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
y-eight
reviewed
Jan 12, 2024
chore: removed dedicated targetManager config
puffitos
approved these changes
Jan 12, 2024
lvlcn-t
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current configuration structure is disorderly, with most options using non-nested, lengthy names. This pull request addresses this issue by reorganizing the configuration layout to utilize nesting, as illustrated below:
Before:
After:
This restructuring enhances the clarity and maintainability of the configuration setup.
Adding a parameter to both the configuration and the Command Line Interface (CLI) currently requires changes in three different locations in the codebase. This pull request aims to streamline and simplify this process.
Closes #47
Changes
Removed flagmapping struct and replaced it with a simple abstraction over Viper and Cobra. The acbstraction provides a unified approach for registering and binding configuration keys to CLI parameters. This abstraction follows a builder pattern, enhancing code structure and maintainability. Also updated helm chart, to reflect the changes to the config.
For additional details, refer to the commit history.
Tests done