-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/openapi generation #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-eight
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed & refactored together... LGTM
lvlcn-t
pushed a commit
that referenced
this pull request
Jan 29, 2024
* feat: added workflow to prune old images (#1) * fix: added runs-on variable (#2) * feat: trying new regex (#3) * fix: trying commit as expression (#4) * fix: trying keep tags (#5) * beingtoospecific (#6) * fix: regex expression fixed (#7) * fix: new regex (#8) * Test (#9) * fix: new regex * test * fix: fixed regex hopefully (#10) * fix: pruning snapshots (#11) * feat: added new workflow to prune old images for packages sparrow and charts/sparrow * fix: removed keep-last conditions * fix: removed comments * fix: removed unnecessary permission declaration * fix: removed dry-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implements dynamic openapi schemas based on the registered checks
Concept
I have added a new method
Schema()
to the check interface which has to return an OpenAPI schema of the Result including its metrics type as the data attribute. To make this easier and less prone to errors, a helper function is also provided. An example of how to implement this can be found in the roundtrip check.Below is a sample of what is generated by sparrow:
Changes
Tests done
TODO